----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74351/#review225316 -----------------------------------------------------------
Ship it! Ship It! - Dhaval Rajpara On March 19, 2023, 7:26 p.m., Mugdha Varadkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74351/ > ----------------------------------------------------------- > > (Updated March 19, 2023, 7:26 p.m.) > > > Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, and Nikunj > Pansuriya. > > > Bugs: RANGER-4097 > https://issues.apache.org/jira/browse/RANGER-4097 > > > Repository: ranger > > > Description > ------- > > On deleting all the services from the service headers inside a zone in > resource policy page and removing the zone name from zone filter it refreshes > the page but instead of just removing services from those service headers > which are targeted in zone all the services inside all the service headers > are gone. > > > Steps to reproduce: > > 1. Create a zone named "temp_zone" and select cm_hive as the service from > Hadoop SQL service header. > 2. Navigate to resources based policies page and select "temp_zone" from > the dropdown security zone. > 3. Click on delete icon of the "cm_hive" service inside zone. > 4. Then remove the filter of "temp_zone" from security zone search bar. > 5. Then the resource based policy page loads but all the services inside > service headers are gone for all the services instead of only those service > headers whose all services are deleted. > > NOTE: After refreshing the page everything works fine. > > > The fix provided, is also handling RANGER-4098 issue. > > > Diffs > ----- > > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx > 5a3f36dcf > > > Diff: https://reviews.apache.org/r/74351/diff/1/ > > > Testing > ------- > > Tested changes on a cluster setup with Ranger Admin build with react code > base. > > Successful completion of build command : > mvn clean compile package -DskipTests -Psecurity-admin-react > > > Thanks, > > Mugdha Varadkar > >
