----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74385/#review225366 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On April 11, 2023, 3:01 p.m., Alvin Wo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74385/ > ----------------------------------------------------------- > > (Updated April 11, 2023, 3:01 p.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > ------- > > The project has a dependency on org.glassfish:javax.el:jar, which is required > for org.glassfish.web:javax.servlet.jsp. However, javax.servlet.jsp doesn't > specify an upper bound version of javax.el. This can cause SNAPSHOT > dependencies to be included when building the project. To address this, we > plan to exclude javax.el and manually add it as a dedicated dependency with a > specific version. > > Similar issues: > https://issues.apache.org/jira/browse/JCR-4626 > https://issues.apache.org/jira/browse/HBASE-22318 > > > Diffs > ----- > > hbase-agent/pom.xml c6acf9756 > hive-agent/pom.xml 27b5ab314 > pom.xml 2128e2cd5 > ranger-hbase-plugin-shim/pom.xml add905f46 > ranger-hive-plugin-shim/pom.xml 61dd7cfb7 > > > Diff: https://reviews.apache.org/r/74385/diff/2/ > > > Testing > ------- > > 1. pass all the unit tests: `mvn clean compile package install > -Drat.skip=true -P 'ranger-jdk11,!linux'` > 2. in the file `distro/src/main/assembly/hive-agent.xml`, it doesn't include > the jar file `org.glassfish:javax.el` so I think it's not a runtime > dependency for ranger-hive-plugin > > > Thanks, > > Alvin Wo > >
