----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74401/#review225394 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On April 17, 2023, 11:43 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74401/ > ----------------------------------------------------------- > > (Updated April 17, 2023, 11:43 p.m.) > > > Review request for ranger, madhan, Madhan Neethiraj, and Pradeep Agrawal. > > > Repository: ranger > > > Description > ------- > > When an ENTITY_UPDATE notification is processed by tagsync process, it > invokes Ranger admin's TagREST.importServiceTags() REST endpoint to add or > update corresponding service-resource. However, if the incoming > service-resource contains a GUID value, and Ranger admin's database does not > have a service-resource that matches the GUID value, then instead of > searching the database for the resource-signature, the implementation tries > to create a service-resource. Such creation may fail with violation of > uniqueness constraint for resource-signature value, resulting in the > notification not correctly handled. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/rest/ServiceTagsProcessor.java > fcbc31a99 > > > Diff: https://reviews.apache.org/r/74401/diff/1/ > > > Testing > ------- > > Compiled clean and ran unit tests successfully > > > Thanks, > > Abhay Kulkarni > >
