----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74403/#review225413 -----------------------------------------------------------
Ship it! Ship It! - Dhaval Rajpara On April 18, 2023, 7:35 p.m., Mugdha Varadkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74403/ > ----------------------------------------------------------- > > (Updated April 18, 2023, 7:35 p.m.) > > > Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Madhan Neethiraj, > Mehul Parikh, and Nikunj Pansuriya. > > > Bugs: RANGER-4194 > https://issues.apache.org/jira/browse/RANGER-4194 > > > Repository: ranger > > > Description > ------- > > In this review request, updating code logic to not show exclude / recursive > option for resource if not supported in service view page. > > Also fixing below changes : > - Showing warning message when user select UDF resource in Hive. > - Removing dev console.log lines from code. > - Handling console warning shown for unique key props. > > > Diffs > ----- > > security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js > 6570fb7f9b4fa47d3188bc36eba90b29819f629c > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx > cfa838a10ce38d9b7c0485c1b53ad286d45aaed7 > security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx > 123d7e0861fda062bf87ceecfd32fe2368b97cf6 > security-admin/src/main/webapp/react-webapp/src/views/Header.jsx > 5d3f26ae8035820826e22a6c35ebdc82b20b3905 > security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx > 833f958113406714568990dea6ac7521db7f6271 > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx > b5b2779e0a52fe28c3a2c4cf98220fd0f8cf9fb6 > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx > fc81caecbad44f4f3a46427416fea126b3df9555 > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx > 462c5cf210c4a0adead1db760bdc9d9dee6691da > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx > 22ba0fd20549a11058024123c436e1ada1bd54de > > security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx > 8e17fb57ea72474d4a073277fa91a41fe568cecf > > security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx > 5620780bc53f1b582689a41f937589a14d5cefd6 > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx > 47ee3f387cbb35bfa843f5c5bdb1bc01d6d79969 > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx > 28a98e5c61f567e99d36d3bfa9ea40a37a377993 > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx > 24fe45675dedd2a4d5c2fec6eee3315a624ae451 > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx > 7d22116c96e79d19d5943eac6906eeb7e35f1674 > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx > 5b60fa6873d96117a563d3b1bb2714306acf8169 > security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx > a1250175408f9477a4ada27512aac2d04eb87d73 > > > Diff: https://reviews.apache.org/r/74403/diff/1/ > > > Testing > ------- > > Tested changes on a cluster setup with Ranger Admin build with react code > base. > > Successful completion of build command : > mvn clean compile package -Psecurity-admin-react > > > Thanks, > > Mugdha Varadkar > >
