----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74422/#review225446 -----------------------------------------------------------
Ship it! Ship It! - Ramesh Mani On April 29, 2023, 8:30 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74422/ > ----------------------------------------------------------- > > (Updated April 29, 2023, 8:30 a.m.) > > > Review request for ranger, Ankita Sinha, Dhaval Rajpara, Abhay Kulkarni, > Mehul Parikh, Monika Kachhadiya, Mugdha Varadkar, Nitin Galave, Ramesh Mani, > Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-4218 > https://issues.apache.org/jira/browse/RANGER-4218 > > > Repository: ranger > > > Description > ------- > > updated to consider users in groups listed in service-config > service.admin.groups as service admins > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java > 155fa357d > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 60903cc97 > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > 691ab52b3 > > > Diff: https://reviews.apache.org/r/74422/diff/1/ > > > Testing > ------- > > - updated unit tests to cover service admins via configuration > service.admin.groups > - verified in Ranger UI that users in groups included in service-config > service.admin.groups are allowed manage policies in the service > > > Thanks, > > Madhan Neethiraj > >
