----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74405/#review225492 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java Line 369 (original), 369 (patched) <https://reviews.apache.org/r/74405/#comment314060> If some exception is thrown here at line 369, dbVersion will be retruned as null, which may cause regression since currently getDBVersion is returning default string "Not Available". We can either initialize with a deafult string value at start of method or in catch method - Subhrat Chaudhary On May 29, 2023, 12:44 p.m., Ramachandran Krishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74405/ > ----------------------------------------------------------- > > (Updated May 29, 2023, 12:44 p.m.) > > > Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, > Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, > Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-4195 > https://issues.apache.org/jira/browse/RANGER-4195 > > > Repository: ranger > > > Description > ------- > > Exposing the Ranger REST API is used to fetch the health check status of > Ranger Admin > > RangerAdmin Health Check JSON Response look like (In the current > implementation) > { > "status": "UP", > "components": { > "db": { > "status": "UP", > "details": > > { "database": "Oracle 21.3c", "validationQuery": "SELECT banner from > v$version where rownum<2" } > } > } > } > In the future we can extend this health check API for other components like > AuditHandler (Elastic search, Kafka,HDFS, Solr),KMS ,etc > Another Example : > { > "status": "UP", > "components": { > "db": { > "status": "UP", > "details": > > { "database": "Oracle 21.3c", "validationQuery": "SELECT banner from > v$version where rownum<2" } > }, > "auditProvider": { > "status": "UP", > "details": > > { "provider": "Elastic Search", "providerHealthCheckEndpoint": > "http://localhost:9200/_cluster/health?pretty"; } > } > } > } > > > As part of this PR ,we have added some refactoring stuffs as well. > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java > 598659bf4 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServerHealth.java > PRE-CREATION > > agents-common/src/test/java/org/apache/ranger/plugin/model/TestRangerHealth.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java > 7a7cc8137 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 04aee289e > security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java > 0d0697990 > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java > 7d4828ed0 > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java > 7f00e9dcb > > security-admin/src/main/java/org/apache/ranger/util/RangerServerHealthUtil.java > PRE-CREATION > security-admin/src/main/resources/conf.dist/security-applicationContext.xml > 807791f28 > security-admin/src/test/java/org/apache/ranger/biz/TestRangerBizUtil.java > 22e290a66 > security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java > 73a593e9f > > security-admin/src/test/java/org/apache/ranger/util/TestRangerServerHealthUtil.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/74405/diff/4/ > > > Testing > ------- > > Tested this API and the response below > {"status":"UP","details":{"components":{"db":{"details":{"database":"ORACLE > Oracle Database 19c Enterprise Edition Release 19.0.0.0.0 - > Production","validationQuery":"SELECT banner from v$version where > rownum<2"},"status":"UP"}}}} > > > Thanks, > > Ramachandran Krishnan > >
