----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74453/#review225513 -----------------------------------------------------------
Fix it, then Ship it! security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java Lines 43 (patched) <https://reviews.apache.org/r/74453/#comment314076> MessageEnums is unused. Please remove. security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java Line 293 (original), 295 (patched) <https://reviews.apache.org/r/74453/#comment314077> Package name "org.apache.commons.lang." is not necessary here, as StringUtils is already imported in this class. - Madhan Neethiraj On May 23, 2023, 4:56 p.m., Ramachandran Krishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74453/ > ----------------------------------------------------------- > > (Updated May 23, 2023, 4:56 p.m.) > > > Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, > Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, > Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-4250 > https://issues.apache.org/jira/browse/RANGER-4250 > > > Repository: ranger > > > Description > ------- > > Ranger throws BAD Request Error when we are not passing exec user to the > getRoles (/public/v2/api/roles/name/{name) > > getGroupsForUser('null') failed javax.ws.rs.WebApplicationException: HTTP 400 > Bad Request| at > org.apache.ranger.common.RESTErrorUtil.createRESTException(RESTErrorUtil.java:56)| > at > org.apache.ranger.common.RESTErrorUtil.createRESTException(RESTErrorUtil.java:325)| > at > org.apache.ranger.service.XUserService.getXUserByUserName(XUserService.java:160)| > at org.apache.ranger.biz.XUserMgr.getXUserByUserName(XUserMgr.java:153)| at > org.apache.ranger.biz.XUserMgr.getGroupsForUser(XUserMgr.java:893)| at > org.apache.ranger.biz.XUserMgr$$FastClassBySpringCGLIB$$57c6d473.invoke(<generated>)| > at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)| > at > org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:688)| > at > org.apache.ranger.biz.XUserMgr$$EnhancerBySpringCGLIB$$ab39f3cf.getGroupsForUser(<generated>)| > at org.apache.ranger.rest.RoleREST.getRole(RoleREST.java:301)| at > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4f0edd2b0 > > > Diff: https://reviews.apache.org/r/74453/diff/2/ > > > Testing > ------- > > > Thanks, > > Ramachandran Krishnan > >
