----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74495/#review225572 -----------------------------------------------------------
Ship it! Ship It! - Brijesh Bhalala On June 26, 2023, 12:22 p.m., Dhaval Rajpara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74495/ > ----------------------------------------------------------- > > (Updated June 26, 2023, 12:22 p.m.) > > > Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, > Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nitin > Galave, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-4294 > https://issues.apache.org/jira/browse/RANGER-4294 > > > Repository: ranger > > > Description > ------- > > Delete message alert box should have message specific to delete activity. > > Try to delete service - Observe - Delete message alert box > Try to delete policy - Observe - Delete message alert box > > Both Delete message alert box on same page , no specific details about which > operation is performed > > Earlier in backbone Js both deletion happens of different page . > > > Diffs > ----- > > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx > a27cbaa28 > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx > 77797f966 > > security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx > 0d576d573 > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx > 2f585525d > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx > 3652e6c16 > security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx > 1833d219b > > > Diff: https://reviews.apache.org/r/74495/diff/2/ > > > Testing > ------- > > 1)Build and Verified Ranger Admin setup with this changes. > 2)Verified the following things:- > 1) Checked that message alert box display properly while deleting > Service/Policy/Zone > 2) Message contain Name of policy/zone/service for more infomation > > > Thanks, > > Dhaval Rajpara > >
