----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74500/#review225580 -----------------------------------------------------------
Ship it! Ship It! - Mugdha Varadkar On June 27, 2023, 12:54 p.m., Dhaval Rajpara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74500/ > ----------------------------------------------------------- > > (Updated June 27, 2023, 12:54 p.m.) > > > Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, > Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nitin > Galave, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-4263 > https://issues.apache.org/jira/browse/RANGER-4263 > > > Repository: ranger > > > Description > ------- > > Ranger] : plugins/services/lookupResource give bank response in react API > > New react ui hit below api > > https://***2/service/plugins/services/lookupResource/cm_solr > > request data : without userInput > > {"resourceName":"collection","resources":{"collection":[]}} > response : > > 204 = no content > Ideally default resouce should be loaded and below request should be passed > by click action > > {"userInput": "","resourceName":"collection","resources":{"collection":[]}} > > Expected : Default resouces should be lookup , If user clicks on dropdown or > on text field > > 2) Add a loader to select 2 options while changing the resource field. > > 3) If the service definition of resources has singleValue : true then the > user is not able to select more than one value. > > 4) if we enter * in resource value then it will load all the options. > > > Diffs > ----- > > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx > e5c8bc399 > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx > a27cbaa28 > > security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx > ae46317c1 > > security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceSelectComp.jsx > PRE-CREATION > > > Diff: https://reviews.apache.org/r/74500/diff/1/ > > > Testing > ------- > > 1)Build and Verified Ranger Admin setup with this changes. > 2) Validated below scenarios on old and new UI: > 1. Tested Resource Based/Tag Based/ KMS Policy CRUD. > 2. Tested Zone & Unzone policy CRUD. > 3. Tested Security zone CRUD with multiple resources set. > 3) Attached document regarding testing scenario on JIRA > > > Thanks, > > Dhaval Rajpara > >
