-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74528/#review225616
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java
Lines 523 (patched)
<https://reviews.apache.org/r/74528/#comment314099>

    "/user/groups/roles" => "/lookup/principals"



security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java
Lines 525 (patched)
<https://reviews.apache.org/r/74528/#comment314100>

    RangerAPIList.GET_GROUPS_LOOKUP => RangerAPIList.GET_PRINCIPALS_LOOKUP



security-admin/src/main/java/org/apache/ranger/view/VXRangerPrincipalView.java
Lines 21 (patched)
<https://reviews.apache.org/r/74528/#comment314098>

    Please consider using org.apache.ranger.plugin.model.RangerPrincipal 
instead of introducing this new class VXRangerPrincipalView.


- Madhan Neethiraj


On July 26, 2023, 11:43 a.m., Prashant Satam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74528/
> -----------------------------------------------------------
> 
> (Updated July 26, 2023, 11:43 a.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4323
>     https://issues.apache.org/jira/browse/RANGER-4323
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> We get users,groups,roles all we get in response from one API 
> (/xusers/users/groups/roles) we can also pass Query Params like 
> name,isVisible Also we can PartialSearch Name for users,groups,roles
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 
> 9a2253a3d 
>   
> security-admin/src/main/java/org/apache/ranger/view/VXRangerPrincipalView.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/74528/diff/1/
> 
> 
> Testing
> -------
> 
> We get users,groups,roles combined in response from API 
> (/xusers/users/groups/roles) we can pass query params like name(PartialSearch 
> Available),isVisible to filter the users,groups,roles we get in response
> 
> 
> Thanks,
> 
> Prashant Satam
> 
>

Reply via email to