----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74541/#review225645 -----------------------------------------------------------
Ship it! Ship It! - Ramesh Mani On Aug. 9, 2023, 8:03 p.m., Szymon Orzechowski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74541/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2023, 8:03 p.m.) > > > Review request for ranger, Abhishek Kumar and Madhan Neethiraj. > > > Bugs: RANGER-4349 > https://issues.apache.org/jira/browse/RANGER-4349 > > > Repository: ranger > > > Description > ------- > > AtlasTagSource.commitToKafka() is hard coded to commit offset to topic > ATLAS_ENTITIES. The topic to which entity events are sent from Atlas and > received by Ranger Tagsync is determined by > atlas.notification.entities.topic.name property in > atlas-application.properties file. By default, it is ATLAS_ENTITIES but some > might configure it to a different name in which case Tagsync would be > committing offset to the wrong topic. > > > Diffs > ----- > > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java > 071f52c4a > > > Diff: https://reviews.apache.org/r/74541/diff/1/ > > > Testing > ------- > > Checked on my cluster and verified if `mvn clean test` passes > > > Thanks, > > Szymon Orzechowski > >
