----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74564/#review225678 -----------------------------------------------------------
Ship it! Ship It! - Dhaval Rajpara On Aug. 24, 2023, 9:12 a.m., Mugdha Varadkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74564/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2023, 9:12 a.m.) > > > Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Mehul Parikh, and > Nikunj Pansuriya. > > > Bugs: RANGER-4367 > https://issues.apache.org/jira/browse/RANGER-4367 > > > Repository: ranger > > > Description > ------- > > A user with access on keymanager module is not able to view the encryption > tab in react UI, but the same user can view the encryption tab in Backbone > classic/latest UI. > > Steps to reproduce :- > 1. Create a user with admin/user/auditor privileges > 2. Remove permissions for the user on all other modules, and assign > permissions only on keymanager module > 3. Login as the created user > 4. The user cannot see the encryption tab in react ui, but can see it if the > UI is switched to backbone ui > > > Apart for fixing the above issue, also added below changes in this fixes. > Need to restrict below UI operations for user with role - ADMIN_AUDITOR or > KEY_ADMIN_AUDITOR. > > Policy edit from Report page > Export 'json' from Report Page > Add Key button from Key Manager > Key listing page > > However, If user try to perform these operations from UI, "403 Forbidden" > page is shown. But it is good to have restriction on Ranger Admin UI with > react JS. > > > Diffs > ----- > > > security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx > d4f4a24b603a876fe87bf7a10f29e5c0373af071 > > security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx > 0fd79851c43a188b17c93da57ac078b0aa139849 > > security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx > fc4d50093dc96ca9a906f0aa157bc8e997def9b3 > security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBar.jsx > 4dad6cab99bfb8837d31ec425166168218a6becd > > > Diff: https://reviews.apache.org/r/74564/diff/1/ > > > Testing > ------- > > Tested changes on a cluster setup with Ranger Admin build with React JS code > base. > > Successful completion of build command : > mvn clean compile package -Psecurity-admin-react > > > Thanks, > > Mugdha Varadkar > >
