-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74563/#review225677
-----------------------------------------------------------


Ship it!




Ship It!

- Dhaval Rajpara


On Aug. 24, 2023, 8:49 a.m., Mugdha Varadkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74563/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2023, 8:49 a.m.)
> 
> 
> Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Mehul Parikh, and 
> Nikunj Pansuriya.
> 
> 
> Bugs: RANGER-4374
>     https://issues.apache.org/jira/browse/RANGER-4374
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Steps to reproduce :
> 
> 1.Create a user 'testuser1' and password 'Testuser1'
> 2.Login with 'testuser1'
> 3.Go to profile and then change password
> 4.Give some wrong password in 'old password'
> 5.And give some new password
> 6.Click on save
> 
> To handle the above issue, introduced a parameter skipNavigate which needs to 
> be passed to fetchApi() when we need to skip navigating to error page when 
> server side error occurs.
> 
> Also made code clean-up changes in the few existing files.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx 
> 34eb8c5fad465e5a0cd1da9e617993fae87098b8 
>   security-admin/src/main/webapp/react-webapp/src/utils/XAMessages.js 
> 82eb8fe185c346c2b37bef006c3ab7ecb29ae21a 
>   security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 
> 7edee019e3bc7dfd91691f3f40f2a5e563e76051 
>   security-admin/src/main/webapp/react-webapp/src/utils/appState.js 
> 6267de2b4326928f4f06181effd6dd56b2b83de1 
>   security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js 
> ef32634bb480a364b4474c88185f9c3164fbf92d 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogDetail.jsx
>  af64aa87793338271b1d4f9dd2fde65b05bc31e3 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx
>  cf92a9a99bc85db048d6624e60d8f1cc8c04b6f5 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx
>  92a1aac47c9dd82c541d54da50a955575c20b1dc 
>   
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx
>  0a94a3b8507aa0cfb225d2292a8e519855cc78aa 
>   
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx
>  d4f4a24b603a876fe87bf7a10f29e5c0373af071 
>   
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx
>  ea76fa82390877a70ee3c7ca04104649597ab5f1 
>   
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx
>  af1903ec737e6a28d09b562cb4e0e27d3af0dc65 
>   
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceViewDetails.jsx
>  c774504ecbf2276421dece9d1e28acf0f3db7da8 
>   
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBarBody.jsx 
> 4d8494fc4dd87c4e470b4f194c7d56d580bfd20f 
>   
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx
>  73585458a99c18a180e38012887410afbbf70e89 
>   
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx
>  1b32993b7057881e38323a2db3b4bf0cfa4acec8 
>   
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx
>  c3150fd65e48f2a4763947bf2a3e30ddbb1c9c73 
>   security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx 
> 452fe931ebc14961819730b0d4e7865fc416b3c6 
> 
> 
> Diff: https://reviews.apache.org/r/74563/diff/1/
> 
> 
> Testing
> -------
> 
> Tested changes on a cluster setup with Ranger Admin build with React JS code 
> base.
> 
> Successful completion of build command :
> mvn clean compile package -Psecurity-admin-react
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Reply via email to