----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74560/#review225688 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java Lines 461 (patched) <https://reviews.apache.org/r/74560/#comment314143> Nit pick: for better readability its better to have the policy-cache file saving operation to a method. - Ramesh Mani On Aug. 25, 2023, 6:10 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74560/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2023, 6:10 p.m.) > > > Review request for ranger, madhan, Madhan Neethiraj, Mehul Parikh, Pradeep > Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-4379 > https://issues.apache.org/jira/browse/RANGER-4379 > > > Repository: ranger > > > Description > ------- > > Assorted debugging help : > 1. Save policy-cache at Ranger-admin and policy-cache as well as downloaded > policy-deltas on plugin side. > > Relevant configuration variables: > > Plugin: > ranger.plugin.<service-def-name>.preserve.deltas [default:false] > ranger.plugin.<service-def-name>.max.versions.to.preserve [default: 50] > > Ranger Admin: > ranger.admin.policy.save.to.disk [default:false] > ranger.admin.policy.max.versions.to.save.to.disk [default:1] > > 2. Better formatting of Trie dump > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java > 647059203 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 9249b3295 > > agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java > c130309ea > > security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java > 9fda659ac > > > Diff: https://reviews.apache.org/r/74560/diff/2/ > > > Testing > ------- > > > Thanks, > > Abhay Kulkarni > >
