----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74567/#review225692 -----------------------------------------------------------
Ship it! Ship It! - Ramesh Mani On Aug. 26, 2023, 9:16 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74567/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2023, 9:16 p.m.) > > > Review request for ranger, Abhay Kulkarni, Monika Kachhadiya, Pradeep > Agrawal, Ramesh Mani, Subhrat Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-4380 > https://issues.apache.org/jira/browse/RANGER-4380 > > > Repository: ranger > > > Description > ------- > > - updated /server/purge/records REST API to support record type > policy_export_logs > - updated Python client to support API purge_records(record_type, > retention_days) > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPurgeResult.java > PRE-CREATION > intg/src/main/python/apache_ranger/client/ranger_client.py 9731c266c > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 9b02229e1 > > security-admin/src/main/java/org/apache/ranger/db/XXPolicyExportAuditDao.java > deed28e47 > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java > 1bdac859c > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 852c163df > security-admin/src/main/resources/META-INF/jpa_named_queries.xml cf6ebad95 > > > Diff: https://reviews.apache.org/r/74567/diff/1/ > > > Testing > ------- > > - verified that purging works with following Python calls > ``` > >>> from apache_ranger.client.ranger_client import RangerClient > >>> > >>> ranger = RangerClient('http://localhost:6080', ('admin', 'rangerR0cks!')) > >>> > >>> ranger.purge_records('login_records', 10) > [{'recordType': 'login_records', 'totalRecordCount': 8, 'purgedRecordCount': > 8}] > >>> > >>> ranger.purge_records('trx_records', 10) > [{'recordType': 'trx_records', 'totalRecordCount': 293, 'purgedRecordCount': > 293}] > >>> > >>> ranger.purge_records('policy_export_logs', 10) > [{'recordType': 'policy_export_logs', 'totalRecordCount': 130594, > 'purgedRecordCount': 100043}] > >>> > ``` > > > Thanks, > > Madhan Neethiraj > >