> On Aug. 26, 2023, 11:40 p.m., Abhay Kulkarni wrote: > > security-admin/src/main/java/org/apache/ranger/service/RangerTransactionService.java > > Lines 115 (patched) > > <https://reviews.apache.org/r/74566/diff/3/?file=2279058#file2279058line115> > > > > Is it possible to provide more information about the failed task? > > Perhaps commitWork.toString() can have an implementation which prints the > > details of the scheduled work that was not done as a result of this failure.
Each task logs details of the failure it encountered - in this case, the failures will be from database. Summary here is only a periodic counts of scheduled/executed/pending tasks. Duplicating error details here may not be useful. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74566/#review225691 ----------------------------------------------------------- On Aug. 25, 2023, 8:27 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74566/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2023, 8:27 p.m.) > > > Review request for ranger, Abhay Kulkarni, Monika Kachhadiya, Pradeep > Agrawal, Ramesh Mani, Subhrat Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-4375 > https://issues.apache.org/jira/browse/RANGER-4375 > > > Repository: ranger > > > Description > ------- > > - when ranger.plugin.activity.log.not.modified=false, x_plugin_info record > update is skipped if no changes are downloaded to the plugin > - updated RangerTransactionService to support threadpool size via > configuration > - updated RangerTransactionService to periodically log status of number of > pending tasks > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 1dc3d372d > > security-admin/src/main/java/org/apache/ranger/service/RangerTransactionService.java > 49d07fcd0 > > > Diff: https://reviews.apache.org/r/74566/diff/3/ > > > Testing > ------- > > - verified that update of x_plugin_info record is skipped when no changes are > downloaded to the plugin > - verified following stats logs: > ``` > 2023-08-25 23:18:47,008 [http-nio-6080-exec-1] INFO > [RangerTransactionService.java:156] RangerTransactionService: > tasks(scheduled=1, executed=0, failed=0, pending=1) > 2023-08-25 23:19:47,009 [http-nio-6080-exec-7] INFO > [RangerTransactionService.java:156] RangerTransactionService: > tasks(scheduled=16413, executed=16411, failed=0, pending=2) > 2023-08-25 23:20:47,014 [http-nio-6080-exec-5] INFO > [RangerTransactionService.java:156] RangerTransactionService: > tasks(scheduled=31327, executed=31326, failed=0, pending=1) > 2023-08-25 23:21:47,031 [http-nio-6080-exec-10] INFO > [RangerTransactionService.java:156] RangerTransactionService: > tasks(scheduled=45031, executed=45030, failed=0, pending=1) > 2023-08-25 23:22:47,034 [http-nio-6080-exec-4] INFO > [RangerTransactionService.java:156] RangerTransactionService: > tasks(scheduled=61300, executed=49132, failed=0, pending=12168) > 2023-08-25 23:23:47,064 [http-nio-6080-exec-11] INFO > [RangerTransactionService.java:156] RangerTransactionService: > tasks(scheduled=75351, executed=49134, failed=2, pending=26217) > 2023-08-25 23:24:47,162 [http-nio-6080-exec-2] INFO > [RangerTransactionService.java:156] RangerTransactionService: > tasks(scheduled=92338, executed=49136, failed=3, pending=43202) > 2023-08-25 23:25:47,163 [pool-5-thread-1] INFO > [RangerTransactionService.java:156] RangerTransactionService: > tasks(scheduled=105358, executed=98645, failed=3, pending=6713) > 2023-08-25 23:26:47,192 [http-nio-6080-exec-6] INFO > [RangerTransactionService.java:156] RangerTransactionService: > tasks(scheduled=120623, executed=120622, failed=3, pending=1) > 2023-08-25 23:27:47,193 [http-nio-6080-exec-29] INFO > [RangerTransactionService.java:156] RangerTransactionService: > tasks(scheduled=137638, executed=137637, failed=3, pending=1) > 2023-08-25 23:28:47,194 [http-nio-6080-exec-4] INFO > [RangerTransactionService.java:156] RangerTransactionService: > tasks(scheduled=149134, executed=149133, failed=3, pending=1) > 2023-08-25 23:29:47,196 [http-nio-6080-exec-20] INFO > [RangerTransactionService.java:156] RangerTransactionService: > tasks(scheduled=166921, executed=166920, failed=3, pending=1) > 2023-08-25 23:30:47,222 [http-nio-6080-exec-10] INFO > [RangerTransactionService.java:156] RangerTransactionService: > tasks(scheduled=181683, executed=181682, failed=3, pending=1) > 2023-08-25 23:31:47,228 [http-nio-6080-exec-13] INFO > [RangerTransactionService.java:156] RangerTransactionService: > tasks(scheduled=198283, executed=198282, failed=3, pending=1) > ``` > > > Thanks, > > Madhan Neethiraj > >
