----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74588/#review225745 -----------------------------------------------------------
Fix it, then Ship it! agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java Lines 51 (patched) <https://reviews.apache.org/r/74588/#comment314179> Following members are used only in constructor/getGraalVmConfigs. Consider moving them within the method. - configuration - graalVmConfigsDefault - filenameFilter - Madhan Neethiraj On Sept. 13, 2023, 7:28 a.m., Kishor Gollapalliwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74588/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2023, 7:28 a.m.) > > > Review request for ranger, Dineshkumar Yadav, Abhay Kulkarni, Madhan > Neethiraj, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan > Periasamy. > > > Bugs: RANGER-4401 > https://issues.apache.org/jira/browse/RANGER-4401 > > > Repository: ranger > > > Description > ------- > > Currently the only way of enabling GraalVm features/ options is by passing > JVM options. Which might not be feasible always. Hence we need a plugin > config, which will make GraalVm feature enabling configurable. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/GraalScriptEngineCreator.java > 10c2de6b3 > > > Diff: https://reviews.apache.org/r/74588/diff/2/ > > > Testing > ------- > > 1. mvn clean compile package install > 2. Verified following policy conditions scenarios for hive plugin > 2.1 ctx.getAttributeValue("kg_tag", "name").equals("hivetag"); > 2.2 ctx.getUser().equals("kgtest"); > 2.3 ctx.getUserGroups().size() > 0; > 2.4 ctx.getClientIPAddress().equals("xxx.xx.xxx.xx"); > 2.5 _ctx.request.accessType == 'select'; > 2.6 _ctx.request.user == 'kgtest'; > 2.7 _ctx.request.userGroups.length > 0; > 2.8 Object.keys(_ctx.request.userAttributes).length > 0; > 2.9 Object.keys(_ctx.request.userGroupAttributes).length > 0; > 2.10 Object.keys(_ctx.tags).length > 0; > > > Thanks, > > Kishor Gollapalliwar > >
