----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74601/#review225764 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneDao.java Lines 141 (patched) <https://reviews.apache.org/r/74601/#comment314184> Please consider making securityZoneList, bigger than results.size(). - Kishor Gollapalliwar On Sept. 14, 2023, 5:04 a.m., Dineshkumar Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74601/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2023, 5:04 a.m.) > > > Review request for ranger, Ankita Sinha, Dhaval Rajpara, Kishor > Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Mugdha > Varadkar, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy. > > > Bugs: RANGER-4399 > https://issues.apache.org/jira/browse/RANGER-4399 > > > Repository: ranger > > > Description > ------- > > This patch added open API for SecurityZoneHeaderInfo based on serviceId > service/public/v2/api/zones/zone-headers/for-service?serviceId=1&isTagService=false > > where isTagService is false by default > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZoneHeaderInfo.java > 02927b07b > security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java > 44bca7489 > security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneDao.java > 5f73b64ea > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java > 92ade823b > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 23085a273 > > > Diff: https://reviews.apache.org/r/74601/diff/1/ > > > Testing > ------- > > Tested manualy using curl request > -- for non-tag based service, below curl works > curl -u {user}:{user_pass} -X GET > '{hostname}/service/public/v2/api/zones/zone-headers/for-service?serviceId=1&isTagService=false' > curl -u {user}:{user_pass} -X GET > '{hostname}/service/public/v2/api/zones/zone-headers/for-service?serviceId=1' > > -- for tag based service need to pass isTagService=ture > curl -u {user}:{user_pass} -X GET > '{hostname}/service/public/v2/api/zones/zone-headers/for-service?serviceId=2&isTagService=true' > > > Thanks, > > Dineshkumar Yadav > >
