----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74625/#review225800 -----------------------------------------------------------
security-admin/scripts/install.properties Lines 265 (patched) <https://reviews.apache.org/r/74625/#comment314229> Please take a look at 1. dev-support/ranger-docker/scripts/ranger-admin-install-mysql.properties and 2. dev-support/ranger-docker/scripts/ranger-admin-install-postgres.properties to support this in ranger containers. - Abhishek Kumar On Sept. 27, 2023, 12:26 p.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74625/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2023, 12:26 p.m.) > > > Review request for ranger, Abhishek Kumar, bhavik patel, Dhaval Shah, > Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, > Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-4438 > https://issues.apache.org/jira/browse/RANGER-4438 > > > Repository: ranger > > > Description > ------- > > **Problem Statement:** Currently db_setup.py file does not accepts or add > JAVA_OPTS options in java commands executed from db_setup.py and > changepasswordutil.py file. In certain environment user may need these > options to execute the java commands successfully. > > **Proposed Solution:** > In the proposed patch, db_setup.py and changepasswordutil.py file can read > JAVA_OPTS from environment variable and pass that to java class run command > being executed from the same file. > Alternatively user can provide the same in install.propeties via java_opts > property. setup.sh shall export the java_opts value as JAVA_OPTS environement > variable. > > > Diffs > ----- > > security-admin/scripts/changepasswordutil.py e45dab643 > security-admin/scripts/db_setup.py 24502f4fb > security-admin/scripts/install.properties b8e864e9a > security-admin/scripts/setup.sh 750455f08 > > > Diff: https://reviews.apache.org/r/74625/diff/1/ > > > Testing > ------- > > Steps: > 1. Exported a JAVA_OPTS option '-Xms1g' by running the command export > JAVA_OPTS='-Xms1g' on the console. > 2. Added debug statement in db_setup.py file to print java class run command > which are usually executed when db_setup.py is called. > 2. Executed the setup.sh file > 3. setup.sh command executed succesfully and can see debug logs with added > JAVA_OPTS '-Xms1g' > > > Thanks, > > Pradeep Agrawal > >
