----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74630/#review225807 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Oct. 2, 2023, 10:11 a.m., Subhrat Chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74630/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2023, 10:11 a.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: https://issues.apache.org/jira/browse/RANGER-4435 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4435 > > > Repository: ranger > > > Description > ------- > > We need to support cascading delete for datashare and delete following also: > > 1. delete related requests > 2. delete related sharedResources > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractGdsStore.java > 0c9114aee > agents-common/src/main/java/org/apache/ranger/plugin/store/GdsStore.java > 53fe55336 > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > ce4769569 > security-admin/src/main/java/org/apache/ranger/common/MessageEnums.java > 7be604261 > security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java 56b908625 > > > Diff: https://reviews.apache.org/r/74630/diff/2/ > > > Testing > ------- > > Tested on local with the fix - when the daatashare is delete with API DELETE > - /datashare/dataset/{id}, all the related sharedResources and > dataShareInDataset are also deleted. > > > Thanks, > > Subhrat Chaudhary > >
