-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74631/
-----------------------------------------------------------
(Updated Oct. 4, 2023, 7:59 a.m.)
Review request for ranger, Anand Nadar, Prashant Satam, and Subhrat Chaudhary.
Changes
-------
- addressed review comments, by replacing following REST URLs:
-- /dataset/{id}/policies with /dataset/{id}/policy
-- /project/{id}/policies with /project/{id}/policy
- updated delete policy/project to delete associated policies as well
Repository: ranger
Description
-------
- GDS policies are considered internal to datasets and projects, hence these
policies need to be managed via following REST endpoints only:
-- POST service/gds/dataset/{id}/policy
-- PUT service/gds/dataset/{id}/policy/{policyId}
-- DELETE service/gds/dataset/{id}/policy/{policyId}
-- GET service/gds/dataset/{id}/policy/{policyId}
-- GET service/gds/dataset/{id}/policies
- GDS service-type is excluded from service-def listing, so that UI will not
render services
-- removed resource-service to gds-service linking, as all GDS policies will be
created in an internal service named _gds
- GDS service-def updated to replace "dataset" with "dataset-id", and "project"
with "project-id", to make it easier to deal with renaming of datasets and
projects
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerService.java
e79c5d8e3
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceValidator.java
a9ad08a48
agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractGdsStore.java
91f598bd4
agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractPredicateUtil.java
0c47515ef
agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractServiceStore.java
8632dd6bc
agents-common/src/main/java/org/apache/ranger/plugin/store/GdsStore.java
8c56ec1ff
agents-common/src/main/java/org/apache/ranger/plugin/store/ServicePredicateUtil.java
26c5dd7e3
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPerfTracer.java
3c985c62c
agents-common/src/main/java/org/apache/ranger/services/gds/RangerServiceGds.java
0f03c5a31
agents-common/src/main/resources/service-defs/ranger-servicedef-gds.json
06049183c
intg/src/main/python/apache_ranger/client/ranger_gds_client.py ea42b3e2a
intg/src/main/python/apache_ranger/model/ranger_base.py 2cb06b8bd
ranger-examples/sample-client/src/main/python/sample_gds_client.py 1b0d7a93f
security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql e71facf8e
security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql
8536f651e
security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 05705cd92
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java
136a1309b
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
f2de83e20
security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 15fc1cb44
security-admin/src/main/java/org/apache/ranger/common/AppConstants.java
db0a80aef
security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java
4ffde84bd
security-admin/src/main/java/org/apache/ranger/db/XXGdsDatasetPolicyMapDao.java
PRE-CREATION
security-admin/src/main/java/org/apache/ranger/db/XXGdsProjectPolicyMapDao.java
PRE-CREATION
security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 9ff7f0a68
security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java efe7d4bcc
security-admin/src/main/java/org/apache/ranger/entity/XXGdsDatasetPolicyMap.java
PRE-CREATION
security-admin/src/main/java/org/apache/ranger/entity/XXGdsProjectPolicyMap.java
PRE-CREATION
security-admin/src/main/java/org/apache/ranger/entity/XXServiceBase.java
682e66dd8
security-admin/src/main/java/org/apache/ranger/entity/XXServiceVersionInfo.java
54fe0f5b7
security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java f827c754d
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
28ab36bad
security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java
b22208773
security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java
2a28eeb63
security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
8ec558881
security-admin/src/main/java/org/apache/ranger/service/RangerServiceServiceBase.java
5c9591f63
security-admin/src/main/resources/META-INF/jpa_named_queries.xml 41a9bfef6
Diff: https://reviews.apache.org/r/74631/diff/3/
Changes: https://reviews.apache.org/r/74631/diff/2-3/
Testing
-------
- verified that GDS policies can be created via endpoint
service/gds/dataset/{id}/policy
Thanks,
Madhan Neethiraj
