----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74642/#review225818 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java Lines 67 (patched) <https://reviews.apache.org/r/74642/#comment314253> Is it necessary to join XXSecurityZone, given zoneId is already part of XXGdsDataShare? Consider using following: "XXGdsDataShare dsh", "obj.dataShareId = dsh.id" - Madhan Neethiraj On Oct. 4, 2023, 12:50 p.m., Prashant Satam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74642/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2023, 12:50 p.m.) > > > Review request for ranger, Anand Nadar, Madhan Neethiraj, Monika Kachhadiya, > and Subhrat Chaudhary. > > > Bugs: RANGER:4410 > https://issues.apache.org/jira/browse/RANGER:4410 > > > Repository: ranger > > > Description > ------- > > We need additional filters in GET SharedResource GET by zoneId,zoneName > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java > 6a963da60 > > > Diff: https://reviews.apache.org/r/74642/diff/1/ > > > Testing > ------- > > Create dataShare link a sharedResource to it we can get sharedResource by > zoneId,zoneName > Query params supported = zoneId,zoneNamePartial,zoneName > > > Thanks, > > Prashant Satam > >
