----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74645/#review225827 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java Lines 1422 (patched) <https://reviews.apache.org/r/74645/#comment314257> Instead of retrieving RangerDatasetInProjectList, consider following: XXGdsDatasetInProjectDao dao = daoMgr.getXXGdsDatasetInProject(); List<XXGdsDatasetInProject> dipList = dao.findByDatasetId(datasetId); for (XXGdsDatasetInProject dip : dipList) { LOG.debug("removing dataset-in-project: datasetId={}, projectId={}", dip.getDatasetId(), dip.getProjectId()); dao.remove(dip); } security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java Lines 1437 (patched) <https://reviews.apache.org/r/74645/#comment314258> Instead of retrieving RangerDataShareInDatasetList, consider following: XXGdsDataShareInDatasetDao dao = daoMgr.getXXGdsDataShareInDataset(); List<XXGdsDataShareInDataset> dshInDsList = dao.findByDatasetId(datasetId); for (XXGdsDataShareInDataset dshInDs : dshInDsList) { LOG.debug("removing dataShare-in-dataset: dataShareId={}, datasetId={}", dshInDs.getDataShareId(), dshInDs.getDatasetId()); dao.remove(dshInDs); } - Madhan Neethiraj On Oct. 6, 2023, 7:19 a.m., Prashant Satam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74645/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2023, 7:19 a.m.) > > > Review request for ranger, Anand Nadar, Madhan Neethiraj, Monika Kachhadiya, > and Subhrat Chaudhary. > > > Bugs: RANGER:4436 > https://issues.apache.org/jira/browse/RANGER:4436 > > > Repository: ranger > > > Description > ------- > > when dataset is deleted it should delete dataset-policy,dataset mapping for > dataShare,project > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/store/AbstractGdsStore.java > 7b3677e30 > agents-common/src/main/java/org/apache/ranger/plugin/store/GdsStore.java > 2dadf2cd4 > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > 42a2fa16c > security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java b7ef9b86a > > > Diff: https://reviews.apache.org/r/74645/diff/1/ > > > Testing > ------- > > Steps > 1) create dataset > 2) create dataShare > 3) create project > 4) map dataset to dataShare,project > 5) create policy for dataset > 6) delete dataset by param forceDelete API ===> > /service/gds/dataset/{datasetID}?forceDelete=true > it will delete dataset,mapping of dataset with dataShare and project,policy > created for the dataset > > > Thanks, > > Prashant Satam > >
