----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74650/#review225840 -----------------------------------------------------------
Fix it, then Ship it! agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java Line 496 (original), 496 (patched) <https://reviews.apache.org/r/74650/#comment314264> Consider renaming dataShareRequests to dataShares, to avoid introducing terminology "Request". agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java Lines 590 (patched) <https://reviews.apache.org/r/74650/#comment314265> Consider renaming datasetRequests to datasets, to avoid introducing terminology "Request". - Madhan Neethiraj On Oct. 8, 2023, 6:49 p.m., Subhrat Chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74650/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2023, 6:49 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: https://issues.apache.org/jira/browse/RANGER-4464 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4464 > > > Repository: ranger > > > Description > ------- > > We need a new API to get DataShare summary. The fields datasetId, > datasetName, dataShareId, dataShareName are added to the model > RangerGds.DataShareInDatasetSummary to be used in DataShareSummary for > dataShare listing and request listing page also. There response for dataShare > summary will be: > > { > "id": 4, > "guid": "cb134c01-e49b-4ec9-9c3a-c5b8e8928c40", > "isEnabled": true, > "createdBy": "mark", > "updatedBy": "mark", > "createTime": 1696686411528, > "updateTime": 1696686411530, > "version": 1, > "name": "DSH4", > "permissionForCaller": "ADMIN", > "resourceCount": 0, > "serviceId": 1, > "serviceName": "hive1", > "serviceType": "hive", > "zoneId": 2, > "zoneName": "zone1", > "datasets": [ > { > "guid": "e0b0eae3-25e3-4479-bc9f-c3eb0eb430ea", > "isEnabled": true, > "createdBy": "Admin", > "updatedBy": "Admin", > "createTime": 1696439551228, > "updateTime": 1696439551233, > "version": 1, > "datasetId": 1, > "datasetName": "DS1", > "shareStatus": "REQUESTED", > "approver": "mark" > } > ] > } > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java > cf67d74fd > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > dce45729f > security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java cc09506f3 > > security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java > 1c42e93c0 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDataShareService.java > 773fcb873 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetService.java > 344b4ec33 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsProjectService.java > 1da1456a6 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java > 35ea2da8c > > > Diff: https://reviews.apache.org/r/74650/diff/1/ > > > Testing > ------- > > Validated: > 1. All the counts in dataShare summary API are coming as expected. > 2. All the counts in dataset summary API are coming as expected, with updated > response. > 3. ACL evalaution is working as expected for DataShare search API. > > > Thanks, > > Subhrat Chaudhary > >
