----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74660/#review225851 -----------------------------------------------------------
Ship it! Ship It! - Subhrat Chaudhary On Oct. 11, 2023, 6:37 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74660/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2023, 6:37 a.m.) > > > Review request for ranger, Anand Nadar, Ankita Sinha, Abhay Kulkarni, Mehul > Parikh, Ramesh Mani, and Subhrat Chaudhary. > > > Bugs: RANGER-4470 and RANGER-4471 > https://issues.apache.org/jira/browse/RANGER-4470 > https://issues.apache.org/jira/browse/RANGER-4471 > > > Repository: ranger > > > Description > ------- > > - updated GDS store implementation to generate trxLog entries for CRUD > operations on GDS objects > dataset/project/data-share/shared-resource/datashare-in-dataset/dataset-in-project > > Note that this review includes the updates for RANGER-4470 as well. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/authorization/utils/JsonUtils.java > e3c45c1ff > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java > 105044f08 > intg/src/main/python/apache_ranger/model/ranger_gds.py f93d5eef0 > ranger-examples/sample-client/src/main/python/sample_gds_client.py > ceca4ac02 > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql > 331c97027 > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > a0e6c55cc > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > 5a566288a > security-admin/src/main/java/org/apache/ranger/entity/XXGdsDataShare.java > 1d2f6a189 > > security-admin/src/main/java/org/apache/ranger/entity/XXGdsSharedResource.java > 882cd4392 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsBaseModelService.java > bee32c596 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDataShareInDatasetService.java > 4a6963fa4 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDataShareService.java > d4e6ec746 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetInProjectService.java > 5954183b7 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetService.java > d5e2e52bd > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsProjectService.java > f800c90b0 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java > d9eac708c > > security-admin/src/main/java/org/apache/ranger/validation/RangerGdsValidator.java > 03e04e794 > security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js 3313e538c > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx > 6575dae24 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/DataShareInDatasetLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/DataShareLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/DatasetInProjectLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/DatasetLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ProjectLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SharedResourceLogs.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx > 0d30e3224 > > > Diff: https://reviews.apache.org/r/74660/diff/1/ > > > Testing > ------- > > - created/updated/deleted GDS objects using sample_gds_client.py > - verified that Admin audits UI page shows the details of the changes to GDS > objects > > > Thanks, > > Madhan Neethiraj > >
