-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74662/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-4225
    https://issues.apache.org/jira/browse/RANGER-4225


Repository: ranger


Description
-------

@JsonProperty annotation has been added to model classes for mapping the 
properties with their corresponding getter/setter methods. This will not effect 
Ranger's functionality directly, but it will provide consistency in case there 
is Jackson jar conflict (or when/if Jackson is upgraded to version-2).

Please see the Jira for more detailed analysis of the issue 
https://issues.apache.org/jira/browse/RANGER-4225

Basically, some of the model classes do not comply with JavaBean naming 
conventions, therefore it is possible that Ranger may hit this issue 
https://stackoverflow.com/questions/30205006/why-does-jackson-2-not-recognize-the-first-capital-letter-if-the-leading-camel-c

As a reference of the issue, please see 
http://futuretask.blogspot.com/2005/01/java-tip-6-dont-capitalize-first-two.html


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/view/VXAccessAuditList.java 
04f881ae3 
  security-admin/src/main/java/org/apache/ranger/view/VXAssetList.java 
60393ae57 
  security-admin/src/main/java/org/apache/ranger/view/VXAuditMapList.java 
fa34030ed 
  security-admin/src/main/java/org/apache/ranger/view/VXAuditRecordList.java 
a2c0fb306 
  security-admin/src/main/java/org/apache/ranger/view/VXAuthSessionList.java 
32a23b8c1 
  
security-admin/src/main/java/org/apache/ranger/view/VXCredentialStoreList.java 
93dfd5cb4 
  security-admin/src/main/java/org/apache/ranger/view/VXGroupGroupList.java 
74d30371e 
  security-admin/src/main/java/org/apache/ranger/view/VXGroupList.java 
43650bffe 
  
security-admin/src/main/java/org/apache/ranger/view/VXGroupPermissionList.java 
2e8a83458 
  security-admin/src/main/java/org/apache/ranger/view/VXGroupUserList.java 
4b5a5f92c 
  security-admin/src/main/java/org/apache/ranger/view/VXKmsKeyList.java 
ad65e772c 
  security-admin/src/main/java/org/apache/ranger/view/VXModuleDefList.java 
9463b7bb6 
  
security-admin/src/main/java/org/apache/ranger/view/VXModulePermissionList.java 
032e0447a 
  security-admin/src/main/java/org/apache/ranger/view/VXPermMapList.java 
777045d61 
  security-admin/src/main/java/org/apache/ranger/view/VXPermObjList.java 
b23b1c949 
  
security-admin/src/main/java/org/apache/ranger/view/VXPolicyExportAuditList.java
 3e5b5f858 
  security-admin/src/main/java/org/apache/ranger/view/VXPolicyLabelList.java 
d2392f709 
  security-admin/src/main/java/org/apache/ranger/view/VXPolicyList.java 
fc4849c74 
  security-admin/src/main/java/org/apache/ranger/view/VXPortalUserList.java 
b74463e1b 
  security-admin/src/main/java/org/apache/ranger/view/VXRepositoryList.java 
5e9c99b84 
  security-admin/src/main/java/org/apache/ranger/view/VXResourceList.java 
338eaf526 
  security-admin/src/main/java/org/apache/ranger/view/VXStringList.java 
903a0aba8 
  security-admin/src/main/java/org/apache/ranger/view/VXTrxLogList.java 
b28f61a4a 
  
security-admin/src/main/java/org/apache/ranger/view/VXUgsyncAuditInfoList.java 
c2170e8e4 
  security-admin/src/main/java/org/apache/ranger/view/VXUserList.java 8d5be6a44 
  security-admin/src/main/java/org/apache/ranger/view/VXUserPermissionList.java 
cc59e180c 


Diff: https://reviews.apache.org/r/74662/diff/1/


Testing
-------

Built the project and made sure that deserialized responses on UI side have 
correct property names even though Jackson-2 jars are in the classpath, hence 
the corresponding UI components work as expected.


Thanks,

Sercan Tekin

Reply via email to