----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74666/#review225855 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java Lines 275 (patched) <https://reviews.apache.org/r/74666/#comment314278> We can skip getting RangerSecurityZone, we can get zone id and name from xxSecurityZone. security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java Lines 455 (patched) <https://reviews.apache.org/r/74666/#comment314277> @Path("/lookup") should be fine since we have /zones in path at class level. - Subhrat Chaudhary On Oct. 12, 2023, 3:07 p.m., Prashant Satam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74666/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2023, 3:07 p.m.) > > > Review request for ranger, Anand Nadar, Madhan Neethiraj, Monika Kachhadiya, > and Subhrat Chaudhary. > > > Bugs: RANGER-4428 > https://issues.apache.org/jira/browse/RANGER-4428 > > > Repository: ranger > > > Description > ------- > > Need a new API to get list of zones mapped to a service for the Create > Datashare >> Step 2 > Select Service >> Select Zone > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java > 77b89f1fb > security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java > f45cdd396 > > security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceBase.java > 586a6b705 > > security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java > 8acdd9813 > > > Diff: https://reviews.apache.org/r/74666/diff/1/ > > > Testing > ------- > > Create Zones adding service to it you will get List of zones as response on > GET API -----> (/service/zones/lookup/zones) > Query params -----> serviceId,serivceNamePartial > Response------> > { > "startIndex": 0, > "pageSize": 200, > "totalCount": 2, > "resultSize": 2, > "sortType": "asc", > "sortBy": "zoneId", > "queryTimeMS": 1697102766898, > "list": [ > { > "id": 4, > "isEnabled": true, > "name": "Test-Zone-3" > }, > { > "id": 5, > "isEnabled": true, > "name": "Test-Zone4" > } > ], > "listSize": 2 > } > > > Thanks, > > Prashant Satam > >
