----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74670/#review225861 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On Oct. 13, 2023, 12:50 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74670/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2023, 12:50 a.m.) > > > Review request for ranger, Ankita Sinha, Abhay Kulkarni, Mehul Parikh, Monika > Kachhadiya, Ramesh Mani, and Subhrat Chaudhary. > > > Bugs: RANGER-4472 > https://issues.apache.org/jira/browse/RANGER-4472 > > > Repository: ranger > > > Description > ------- > > - updated getResourceACLs() to use appropriate matchType when a tag is found > on the resource and its descendent > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java > c1388abc2 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEngine.java > 04f010a03 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 8ba0b1a7f > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > bf7ebe86a > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java > dcaae9ff1 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyACLs.java > 196755c6e > agents-common/src/test/resources/policyengine/resource_hierarchy_tags.json > PRE-CREATION > > agents-common/src/test/resources/policyengine/test_aclprovider_resource_hierarchy_tags.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/74670/diff/2/ > > > Testing > ------- > > - added unit tests to cover the usecase where a tag is found for the resource > and its decendent > - verified that all existing test cases pass successfully > > > Thanks, > > Madhan Neethiraj > >
