----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74611/ -----------------------------------------------------------
(Updated Oct. 14, 2023, 8:12 p.m.) Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, Monika Kachhadiya, and Prashant Satam. Changes ------- Resolved conflicts Bugs: https://issues.apache.org/jira/browse/RANGER-4415 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4415 Repository: ranger Description ------- In Dataset details page - Add datashare - user can select multiple datasets and send request to dataset owner. We need a new POST API that can accept request for multiple datashares. Added API /dataset/{id}/datashare to accept List<RangerDataShareInDataset> and return List<RangerDataShareInDataset>. Diffs (updated) ----- security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 4d2a9cc8f security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java 18e4cc451 security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java f21d445c4 Diff: https://reviews.apache.org/r/74611/diff/4/ Changes: https://reviews.apache.org/r/74611/diff/3-4/ Testing (updated) ------- Validated: 1. Addition of multiple datashares in POST API. 2. Tried to add duplicate request (same datashare and dataset ID), 400 is thrown. 3. Tried to add an existing request, with request for 2 new datashares in a dataset. API failed for all the requests. Following cases validated: Datasets: DS1 - 1 - mark - admin DS2 - 2 - joe - admin DataShares: DSH1 - 1 - joe - admin DSH2 - 2 - mark - admin DSH2 - 3 - mark, joe - admin Calling API as mark - http://localhost:6080/service/gds/dataset/1/datashare FAILED: [ { "dataShareId": 1, "datasetId": 1, "status": "ACTIVE" }, { "dataShareId": 2, "datasetId": 1, "status": "GRANTED" } ] Passed: [ { "dataShareId": 2, "datasetId": 1, "status": "GRANTED" }, { "dataShareId": 3, "datasetId": 1, "status": "ACTIVE" } ] Thanks, Subhrat Chaudhary
