----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74674/#review225864 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java Line 279 (original), 279 (patched) <https://reviews.apache.org/r/74674/#comment314282> bizUtil.isAdmin() should be the first check, since if user is ranger-admin, no other check is needed - Subhrat Chaudhary On Oct. 16, 2023, 4:27 p.m., Prashant Satam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74674/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2023, 4:27 p.m.) > > > Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, > Monika Kachhadiya, and Subhrat Chaudhary. > > > Bugs: RANGER-4475 > https://issues.apache.org/jira/browse/RANGER-4475 > > > Repository: ranger > > > Description > ------- > > In Security-Zone summary API the RANGER-ADMIN should have access for all > Security-Zones > > API ===> (service/zones/summary) > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneDBStore.java > 77b89f1fb > > > Diff: https://reviews.apache.org/r/74674/diff/1/ > > > Testing > ------- > > 1)Create a Security-Zone (don't add public to the Admin/Auditor groups while > creating the zone) > 2)create a user with ADMIN role > 3)Get all zones list by API ===> (service/zones/summary) using the created > ADMIN user > > RESPONSE==================> > { > "startIndex": 0, > "pageSize": 1, > "totalCount": 3, > "resultSize": 1, > "sortType": null, > "sortBy": null, > "queryTimeMS": 1697453632943, > "list": [ > { > "id": 2, > "isEnabled": true, > "createdBy": "Admin", > "updatedBy": "Admin", > "createTime": 1697192551000, > "updateTime": 1697192551000, > "name": "Test-Zone-1", > "description": "Test-Zone-1", > "totalResourceCount": 1, > "adminCount": { > "GROUP": 1, > "ROLE": 0, > "USER": 2 > }, > "auditorCount": { > "GROUP": 1, > "ROLE": 0, > "USER": 1 > }, > "services": [ > { > "id": 1, > "name": "Ranger_hive", > "type": "hive", > "resourceCount": 1 > } > ] > } > ], > "listSize": 1 > } > > > Thanks, > > Prashant Satam > >
