----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74685/#review225891 -----------------------------------------------------------
Ship it! Ship It! - Ramesh Mani On Oct. 19, 2023, 7:37 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74685/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2023, 7:37 p.m.) > > > Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay > Kulkarni, Monika Kachhadiya, Pradeep Agrawal, Prashant Satam, Ramesh Mani, > and Subhrat Chaudhary. > > > Bugs: RANGER-4485 > https://issues.apache.org/jira/browse/RANGER-4485 > > > Repository: ranger > > > Description > ------- > > refactored instantiation of conditions evaluators in > RangerCustomerConditionEvaluator to avoid code duplication > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerCustomConditionEvaluator.java > 6f15eed8e > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > 8e908f6a9 > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyItemEvaluator.java > 2528aeafa > > agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java > 53eb0f81e > security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java > 83f662518 > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java > dcbfbfdc2 > > security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefService.java > 31f698292 > > > Diff: https://reviews.apache.org/r/74685/diff/1/ > > > Testing > ------- > > - verified that all existing tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
