-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74715/#review225923
-----------------------------------------------------------



Subhrat - consider using existing API endpoint 
"/api/zones/{zoneId}/service-headers". Though this API doesn't support lookup 
by zoneName, this shouldn't be needed for UI as it should already have the 
zoneId.

- Madhan Neethiraj


On Nov. 2, 2023, 2:03 p.m., Subhrat Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74715/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2023, 2:03 p.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, 
> Monika Kachhadiya, Prashant Satam, and Siddhesh Phatak.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/RANGER-4432
>     
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4432
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> We need a new API for service lookup, with additional support for zoneId and 
> zoneName. This will be used in GDS >> DataShare Listing >> Create DataShare 
> >> Basic Details (Step 1) >> Select Zone >> Get all services related to the 
> security zone. Pagination support is also needed.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> 00a3d9c47 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
> 77ea510a7 
>   
> security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java
>  f21d445c4 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceServiceBase.java
>  fa23b96d7 
> 
> 
> Diff: https://reviews.apache.org/r/74715/diff/1/
> 
> 
> Testing
> -------
> 
> Validations done:
> GET API /service/plugins/services/lookup
> 1. No query params: Validated all the available services are available in 
> response.
> 2. Validated query params: zoneId, zoneName, pageSize, startIndex.
> 
> 
> Thanks,
> 
> Subhrat Chaudhary
> 
>

Reply via email to