----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74720/#review225944 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Nov. 7, 2023, 7:36 a.m., Anand Nadar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74720/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2023, 7:36 a.m.) > > > Review request for ranger, Ankita Sinha, Brijesh Bhalala, Dhaval Rajpara, > Madhan Neethiraj, Mugdha Varadkar, Prashant Satam, and Subhrat Chaudhary. > > > Bugs: https://issues.apache.org/jira/browse/RANGER-4283 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4283 > > > Repository: ranger > > > Description > ------- > > UI Design changes for add principal, internal tab listing and CSS changes > > > Diffs > ----- > > security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx > 98495f6cc > security-admin/src/main/webapp/react-webapp/src/styles/style.css 7cb54b7dc > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/AccessGrantForm.jsx > 32c48046c > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/AddDatasetView.jsx > b337ce009 > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetDetailFullView.jsx > 25f830443 > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetDetailLayout.jsx > 779ab523b > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetPolicyItemComp.jsx > 6bc775143 > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatashareInDatasetListComp.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/MyDatasetListing.jsx > 3bf4347cd > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/PrinciplePermissionComp.jsx > d0b8fadf7 > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/AddDatashareView.jsx > 57194742d > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/AddSharedResourceComp.jsx > b6cc774ef > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/DatashareDetailFullView.jsx > a315de5e1 > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/DatashareDetailLayout.jsx > c0c52aea6 > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/MyDatashareListing.jsx > cef56559c > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Request/RequestDetailView.jsx > d6bfe7cf4 > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Request/RequestListing.jsx > 60b96699f > > > Diff: https://reviews.apache.org/r/74720/diff/1/ > > > Testing > ------- > > Validated dataset/datashare listing with sorting by datasetName and > datashareName > Validated shared resource listing, add/edit/delete of shared resource after > new UI design. > Validated internal datashare listing tab of dataset detail view for new UI > design. > Validated add principal changes after new UI design. > Validated dependant service and zone selection in datashare creation. > > > Thanks, > > Anand Nadar > >
