----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74725/#review225947 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Nov. 8, 2023, 4:53 p.m., Subhrat Chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74725/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2023, 4:53 p.m.) > > > Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, > Monika Kachhadiya, Prashant Satam, and Siddhesh Phatak. > > > Bugs: RANGER-4517 > https://issues.apache.org/jira/browse/RANGER-4517 > > > Repository: ranger > > > Description > ------- > > The sort param sortType is not considered if sortBy is not passed in the > query-param. Please consider following case: > The GET API /service/gds/dataset has default sortType=asc and > sortBy=datasetId. If only sortType=desc is passed in query-param, sorting is > done in asc order and same is updated in response sortType=asc. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/common/RangerConstants.java > f00ea05ca > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > ecb48e251 > > > Diff: https://reviews.apache.org/r/74725/diff/1/ > > > Testing > ------- > > Validate sortBy and sortType params are working as expected. Use cases > validated: > 1. sortBy=datasetName, sortType=asc > 2. sortBy=datasetName, sortType=not passed (asc considered) > 3. sortBy=datasetName, sortType=desc > 4. sortBy=datasetId, sortType=asc > 5. sortBy=datasetId, sortType=not passed (asc considered) > 6. sortBy=datasetId, sortType=desc > 7. sortBy=createTime, sortType=asc > 8. sortBy=createTime, sortType=desc > 9. sortBy=createTime, sortType=not passed (asc considered) > > > Thanks, > > Subhrat Chaudhary > >
