> On Nov. 21, 2023, 12:34 a.m., Ramesh Mani wrote: > > agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java > > Line 112 (original), 112 (patched) > > <https://reviews.apache.org/r/74745/diff/1/?file=2283304#file2283304line112> > > > > Does this fields need to be in Ranger UI, then we need to have another > > JIRA to update it.
Yes, Ramesh. Audit UI should be updated for the addition of these 2 new fields. Filed RANGER-4536 to track UI updates. > On Nov. 21, 2023, 12:34 a.m., Ramesh Mani wrote: > > security-admin/src/main/java/org/apache/ranger/service/XAccessAuditService.java > > Lines 133 (patched) > > <https://reviews.apache.org/r/74745/diff/1/?file=2283312#file2283312line133> > > > > Commented-out statement, if not needed please remove. XXAcccessAudit table is no more used in Ranger. We should actually remove classes related to this table from master branch (3.0 release). In the meantime, I will update this patch to revert changes in this file. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74745/#review225975 ----------------------------------------------------------- On Nov. 20, 2023, 11:32 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74745/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2023, 11:32 p.m.) > > > Review request for ranger, Anand Nadar, Ankita Sinha, Brijesh Bhalala, Dhaval > Rajpara, Abhay Kulkarni, Mehul Parikh, Monika Kachhadiya, Mugdha Varadkar, > Ramesh Mani, Subhrat Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-4282 > https://issues.apache.org/jira/browse/RANGER-4282 > > > Repository: ranger > > > Description > ------- > > - updated AuthzAuditEvent with 2 new fields: datasets, projects > - updated plugin to populate these 2 new fields in generated audit logs > - updated Solr and Elasticsearch schema to add new fields > - RANGER-4536 tracks audit UI updates to support the new fields > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/destination/ElasticSearchAuditDestination.java > 1b17a934b > > agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java > f2e96bf9b > > agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java > e20d1a786 > > agents-audit/src/main/java/org/apache/ranger/audit/provider/solr/SolrAuditProvider.java > 9cda3f8f3 > > agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java > c99465d7a > dev-support/ranger-docker/config/solr-ranger_audits/managed-schema > c33f6de06 > > security-admin/contrib/elasticsearch_for_audit_setup/conf/ranger_es_schema.json > 801667bce > security-admin/contrib/solr_for_audit_setup/conf/managed-schema c33f6de06 > > security-admin/src/main/java/org/apache/ranger/amazon/cloudwatch/CloudWatchAccessAuditsService.java > 0b36f6e90 > > security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java > 4c9b049a0 > > security-admin/src/main/java/org/apache/ranger/service/XAccessAuditService.java > 4d96df6ea > > security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java > bb279349a > security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java > cce18fafb > > > Diff: https://reviews.apache.org/r/74745/diff/1/ > > > Testing > ------- > > - verified audit logs written to Solr include datasets and projects > associated with the resource > - verified audit logs retrieved via REST API calls include datasets and > projects > > > Thanks, > > Madhan Neethiraj > >
