-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74701/
-----------------------------------------------------------
(Updated Nov. 21, 2023, 6:11 a.m.)
Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj,
Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4493
https://issues.apache.org/jira/browse/RANGER-4493
Repository: ranger
Description
-------
In Ranger admin, security zones can be now created without any
services/resources.
If a security zone is created without any service, and on the service manager
page,
if the resource based services are filtered based on the zone without any
service,
then the UI displays an image with the text "No Services".
But if the same service filtering is done for tag based services, then the UI
shows a service element for tag.
It will be better if the UI behaviour is consistent for both resource and tag
based service filtering
In the current review request, I have improvise the code with following fixes :
1)Fix for the No service page in tag based.
2)Fix for the deleting the zone service while filtering zone.
3)Fix for import and export button click when there are no service while
filtering zone.
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/views/Home.jsx 67f71ec79
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx
8c222d080
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx
47763fb9d
security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx
d4dbc57d1
Diff: https://reviews.apache.org/r/74701/diff/3/
Testing (updated)
-------
Tested changes on a cluster setup with Ranger Admin build with React JS code
base.
Verified the "Resource Based Policies" & "Tag Based Policies" Module.
Verified the policy listing page.
Thanks,
Brijesh Bhalala
