----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74748/#review225993 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Nov. 21, 2023, 10:22 a.m., Prashant Satam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74748/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2023, 10:22 a.m.) > > > Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, > Monika Kachhadiya, Subhrat Chaudhary, and Vanita Ubale. > > > Bugs: RANGER-4541 > https://issues.apache.org/jira/browse/RANGER-4541 > > > Repository: ranger > > > Description > ------- > > When we create/update RangerDataShareInDataset object we check if current > user is (dataset admin/datashare admin) this step should be skipped if the > current user is Ranger-Admin > > Example: > > 1)From Ranger-Admin account create datashare and shared-resource > > 2)From USER account create dataset > > 3)From Ranger-Admin account add the datashare to dataset with status as > ACTIVE we get error -------> reason[User is not an admin for dataset] , But > the user is Ranger-Admin > > 4)Expected : Ranger-Admin should be able to add datashare to dataset in > ACTIVE status directly > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/validation/RangerGdsValidator.java > 6c55fd029 > > > Diff: https://reviews.apache.org/r/74748/diff/1/ > > > Testing > ------- > > Steps to Check > 1)From Ranger-Admin account create datashare and shared-resource > > 2)From USER account create dataset > > 3)From Ranger-Admin account add the datashare to dataset with status as > ACTIVE > > 4)Ranger-Admin is directly able to add datashare to dataset with status as > ACTIVE > > > Thanks, > > Prashant Satam > >
