-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74763/
-----------------------------------------------------------
Review request for ranger, Abhishek Kumar, bhavik patel, Dhaval Shah,
Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj,
Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-4545, RANGER-4546, RANGER-4547, RANGER-4548, RANGER-4549,
RANGER-4550, RANGER-4551, RANGER-4552, RANGER-4553, RANGER-4554, and RANGER-4555
https://issues.apache.org/jira/browse/RANGER-4545
https://issues.apache.org/jira/browse/RANGER-4546
https://issues.apache.org/jira/browse/RANGER-4547
https://issues.apache.org/jira/browse/RANGER-4548
https://issues.apache.org/jira/browse/RANGER-4549
https://issues.apache.org/jira/browse/RANGER-4550
https://issues.apache.org/jira/browse/RANGER-4551
https://issues.apache.org/jira/browse/RANGER-4552
https://issues.apache.org/jira/browse/RANGER-4553
https://issues.apache.org/jira/browse/RANGER-4554
https://issues.apache.org/jira/browse/RANGER-4555
Repository: ranger
Description
-------
**Problem Statement:** Ranger REST API responses are not proper. Most of the
legacy REST API's response format are not correct and gives false information.
**Proposed Solution:** This review request shall address multiple issues
related to old APIs.
The list of issues which shall be addressed with review request are :
RANGER-4555: Response metrics for /assets/assets API not proper
RANGER-4554: Response metrics for /assets/resources not proper
RANGER-4553: Response metrics for /xaudit/trx_log not proper
RANGER-4552: Response metrics for /assets/report is not proper, and pagination
does not work
RANGER-4551: No response returned for /assets/policyList/{service_name} API
RANGER-4550: API request to /assets/resource/{id} returns no response
RANGER-4549: Non admin users cannot access /public/v2/api/roles/names and
/public/v2/api/roles/name/{name} API, but can access /public/v2/api/roles API
RANGER-4548: Return proper error message in the response for /tags/tags,
/tags/resources and /tags/types API for non admin users
RANGER-4547: The reponse metrics (pagination values) for the
/assets/ugsyncAudits/{sync_source} API is not proper
RANGER-4546: /assets/ugsyncAudits/{sync_source} API is accessible by user
without permission on audit module
RANGER-4545: DELETE /assets/resources/{resource_id} API should return proper
status code for non admin users
Note: For individual issue fix please refer patch file attached in the
respective jira tickets.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 8bbeba783
security-admin/src/main/java/org/apache/ranger/biz/XAuditMgrBase.java
c90296cf6
security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java abc324dd1
security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4bfaa862c
security-admin/src/main/java/org/apache/ranger/rest/TagREST.java 6d0019f70
security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java
9d9e0bbc0
security-admin/src/main/java/org/apache/ranger/service/XUgsyncAuditInfoService.java
7fa96fbd0
security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java
cc0d75872
security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java
2da72a1ea
security-admin/src/test/java/org/apache/ranger/rest/TestTagREST.java
570ce874b
Diff: https://reviews.apache.org/r/74763/diff/1/
Testing
-------
Tested affected REST APIs using curl command and found the response as per the
expectation.
Thanks,
Pradeep Agrawal
