----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74766/ -----------------------------------------------------------
Review request for ranger, Fateh Singh, madhan, Madhan Neethiraj, Mahesh Bandal, Pradeep Agrawal, Ramesh Mani, and Sailaja Polavarapu. Repository: ranger Description ------- Ranger's performance tracing module supports tracking the time spent in specified API(s), as specified in the log4j configuration file. Sometimes it is useful to collect the performance data when an API is called frequently, and instead of tracking performance of a single invocation of the API it is more interesting to see how API performed over a large number of invocations. This Jira addresses this requirement. The following configuration parameters are introduced to control the behavior of Ranger's performance tracking to enable collecting statistical data. ranger.perf.aggregate.data - If set to true, the performance data is recorded for specified APIs in aggregate, else data for each API call is printed (default:false) ranger.perf.aggregate.data.dump.interval - If set to value more than 0, aggregate performance data is printed with specified periodicity in seconds (default:0) ranger.perf.aggregate.data.lock.enabled - If set to true, aggregate performance data is updated using R-W lock, otherwise locking is not used (default:false). Diffs ----- agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java 2f4af9763 agents-common/src/main/java/org/apache/ranger/plugin/util/PerfDataRecorder.java dce60b0ba agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPerfCollectorTracer.java ebfebdae8 agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPerfTracer.java c8804739f Diff: https://reviews.apache.org/r/74766/diff/1/ Testing ------- Passes all unit tests. Verified that the aggregate performance is collected at specified intervals when properly configured. Thanks, Abhay Kulkarni
