-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74780/
-----------------------------------------------------------
Review request for ranger, Mehul Parikh and Pradeep Agrawal.
Bugs: RANGER-4564
https://issues.apache.org/jira/browse/RANGER-4564
Repository: ranger
Description
-------
RANGER-4564: DELETE /groupsgroups/{id} API doesn't work as forceDelete is
hardcoded to false.
In this change, the value is hardcoded to false, and then it is fetched from
the request parameters,
and force delete is set true only if forceDelete is set true in the request
parameters.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9a2253a3d
Diff: https://reviews.apache.org/r/74780/diff/1/
Testing
-------
Testing done :-
1. Created a groupgroup
2. Tried deleting the groupgroup using id without forceDelete param, the
groupgroup is not deleted and was returned using a GET request
3. Tried deleting the groupgroup using id with request param forceDelete=false,
the group was not deleted, and it was returned using a GET request
4. Tried deleting the groupgroup using id with request param forceDelete=true,
and also with param forceDelete=True, the groupgroup was deleted
5. Tried deleting the groupgrouo using id with request param
forceDelete=random_string, the group is not deleted, and returned using a GET
request
Thanks,
Abhishek Patil