-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74778/#review226035
-----------------------------------------------------------



This is a great idea! It's very useful to have all dynamic expressions in one 
place!

One example is incorrect, though:  "data_source in (${{USER.allowedSources}})". 
 The problem is that IN requires an array on the RHS, but 
(${{USER.allowedSources}}) evaluates to "(source1, source2)." Using 
GET_USER_ATTR_Q just adds quotes around yields "source1, source2", but it 
doesn't create an array.  A split is needed, or the notation 
[[USER.allowedSources]], a la RANGER-2434.

- Barbara Eckman


On Dec. 11, 2023, 2:16 a.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74778/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2023, 2:16 a.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Abhay Kulkarni, Monika 
> Kachhadiya, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and 
> Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4587
>     https://issues.apache.org/jira/browse/RANGER-4587
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> added blog with details of using dynamic expressions in Apache Ranger policies
> 
> 
> Diffs
> -----
> 
>   docs/src/site/resources/blogs/dynamic_expressions.html PRE-CREATION 
>   docs/src/site/xdoc/blogs.xml 2f81ef7c4 
> 
> 
> Diff: https://reviews.apache.org/r/74778/diff/1/
> 
> 
> Testing
> -------
> 
> - built and ran updated docs with mvn site:run
> - verified that the new blog is seen in the blog list
> - verified that the new blog renders correctly in browser
> 
> 
> File Attachments
> ----------------
> 
> Apache Ranger - dynamic expressions.pdf
>   
> https://reviews.apache.org/media/uploaded/files/2023/12/11/a8d4e7f9-5ec7-4527-9d3c-245c15f49573__Apache_Ranger_-_dynamic_expressions.pdf
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Reply via email to