----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74657/#review226058 -----------------------------------------------------------
Ship it! Ship It! - Pradeep Agrawal On Oct. 10, 2023, 11:03 a.m., Rakesh Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74657/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2023, 11:03 a.m.) > > > Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, > sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-4467 > https://issues.apache.org/jira/browse/RANGER-4467 > > > Repository: ranger > > > Description > ------- > > User Agent info missing when login fails. Its good to display this detail as > it helps in knowing how the login was tried in case of failed login attempts > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/SessionMgr.java > 89bffa7c9 > > security-admin/src/main/java/org/apache/ranger/security/listener/SpringEventListener.java > 8f46af968 > > security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthSuccessHandler.java > 52cf17ae1 > > > Diff: https://reviews.apache.org/r/74657/diff/1/ > > > Testing > ------- > > Provided wrong uname or password on Ranger admin UI so that login fails. > Verified login sessions under Audits page that User Agent info is displayed > for Wrong Username/Password > > > Thanks, > > Rakesh Gupta > >