----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74792/#review226067 -----------------------------------------------------------
Ship it! Ship It! - Pradeep Agrawal On Dec. 14, 2023, 4:41 a.m., Abhishek Patil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74792/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2023, 4:41 a.m.) > > > Review request for ranger, Mehul Parikh and Pradeep Agrawal. > > > Bugs: RANGER-4605 > https://issues.apache.org/jira/browse/RANGER-4605 > > > Repository: ranger > > > Description > ------- > > The /assets/resources/count API should return the actual number of policies > (present in knox, hbase, hive and hdfs repos). > However, if the number of policies is greater than 200, then to fetch the > actual number of policies, a parameter "?pageSize" has to be added, and the > response returned is based on the page size parameter. > Ideally, the count returned should not depend on the pageSize parameter. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java > abc324dd1 > > > Diff: https://reviews.apache.org/r/74792/diff/1/ > > > Testing > ------- > > Applied the patch on a cluster and tested the following scenarios :- > 1. Created 100 policies for hdfs, fetched the count using the API endpoint > and ensured that the correct count is returned. > 2. Created 2000 policies for hive, fetched the count using the API, and > ensured that the proper count is returned. > 3. Made a get request to the API endpoint using keyadmin user, and ensured > that the count returned is 0 (0 is the expected value as keyadmin user can > access only kms policies). > > > Thanks, > > Abhishek Patil > >
