----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74808/#review226075 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Dec. 29, 2023, 12:08 p.m., Anand Nadar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74808/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2023, 12:08 p.m.) > > > Review request for ranger, Ankita Sinha, Brijesh Bhalala, Dhaval Rajpara, > Madhan Neethiraj, Mugdha Varadkar, Prashant Satam, and Subhrat Chaudhary. > > > Bugs: https://issues.apache.org/jira/browse/RANGER-4283 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4283 > > > Repository: ranger > > > Description > ------- > > Added default condition & access types in datashare detail view. Fixed bugs > in Add principals. Disabled edit for non admin acl users in access grant. > Removed tag services from service selection dropdown for datashare creation. > > > Diffs > ----- > > security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 030fb596f > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/AccessGrantForm.jsx > 203f40258 > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetDetailLayout.jsx > 95f06c93d > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/PrinciplePermissionComp.jsx > 326433e66 > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/AddDatashareView.jsx > 64819b502 > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/AddSharedResourceComp.jsx > 8d4a1b7d9 > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/DatashareDetailLayout.jsx > adbeca360 > > > Diff: https://reviews.apache.org/r/74808/diff/1/ > > > Testing > ------- > > Validated addtion and updation of default conditions and access types for > datashare. > Validated service drop down to not show tag services. > Validated non editable access grant for non admin/policy-admin users > > > Thanks, > > Anand Nadar > >
