----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74810/#review226083 -----------------------------------------------------------
Ship it! Ship It! - Brijesh Bhalala On Jan. 3, 2024, 8:14 a.m., Mugdha Varadkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74810/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2024, 8:14 a.m.) > > > Review request for ranger, Brijesh Bhalala and Dhaval Rajpara. > > > Bugs: RANGER-4615 > https://issues.apache.org/jira/browse/RANGER-4615 > > > Repository: ranger > > > Description > ------- > > After upgrading to Ranger Admin UI with react code base as default, user will > get the usersync ldap popup details showing server-side data field names > rather than user friendly display names on Ranger Admin UI with React JS. > > The data field names are different in the usersync ldap sync details popup in > ReactJS when compared to backbone JS. > Ideally, both BackBone JS and React JS field names should be the same. > > > Diffs > ----- > > security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js > 194cf3bef4205000bb743c07286d170db7831153 > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > 4caba8f41c765f86aed3bbe870853b413900d06e > > > Diff: https://reviews.apache.org/r/74810/diff/1/ > > > Testing > ------- > > Tested changes on a cluster setup with Ranger Admin build with React JS code > base. > Verified from Ranger Admin UI > Audits > User Sync Tab > having Sync Details > from LDAP. > > > Successful completion of build command : > mvn clean compile package > > > Thanks, > > Mugdha Varadkar > >
