-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74837/
-----------------------------------------------------------
Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Madhan Neethiraj,
Mehul Parikh, Mugdha Varadkar, and Ramesh Mani.
Bugs: RANGER-4653
https://issues.apache.org/jira/browse/RANGER-4653
Repository: ranger
Description
-------
In the service create / update form, an inline assertion has to be added for
displayName validation (length and preventing use of special characters).
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx
abb98954f
Diff: https://reviews.apache.org/r/74837/diff/1/
Testing
-------
Applied the patch on a cluster and tested the following UI scenarios :-
1. Creation of a service with empty displayName, creation succeeded (expected
as displayName is not a mandatory field).
2. Creation of a service with displayName that adheres to the valid regex (no
invalid special characters and length less than 256 characters), service
creation succeeded.
3. Creation of a service with displayName with invalid special characters, form
submission failed (as expected).
4. Creation of a service with displayName length greater than 256 characters,
form submission failed (as expected).
5. Edit a service by modifying the displayName with valid name, edit succeeded.
6. Edit a service by modifying the displayName with invalid special characters,
form submission failed (as expected).
7. Edit a service by modifying the displayName with length greater than 256
characters, form submission failed (as expected).
Thanks,
Abhishek Patil