----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74844/#review226169 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Jan. 18, 2024, 5:21 p.m., Siddhesh Phatak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74844/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2024, 5:21 p.m.) > > > Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, > Monika Kachhadiya, Prashant Satam, Subhrat Chaudhary, and Vanita Ubale. > > > Bugs: RANGER-4663 > https://issues.apache.org/jira/browse/RANGER-4663 > > > Repository: ranger > > > Description > ------- > > If a tag service is selected while creating a resource service, a new tag > service should not be created for this resource service. This has been fixed > by adding the condition to check if user has selected tag service or not. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > f9fd4941e > > > Diff: https://reviews.apache.org/r/74844/diff/1/ > > > Testing > ------- > > Following cases have been tested and working as expected. > Case 1: > 1) Create a service in ranger > 2) Do not select tag service. > 3) A resource service will be created, a new tag service will also get > created and it will be linked to the resource service. > > Case 2: > 1) Create a resource service in ranger. > 2) Select a tag service for it. > 3) A resource service will get created, a new tag service will not get > created and the selected tag service will be linked to the resource service. > > > Thanks, > > Siddhesh Phatak > >
