----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74864/#review226203 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Feb. 7, 2024, 7:25 a.m., Anand Nadar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74864/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2024, 7:25 a.m.) > > > Review request for ranger, Ankita Sinha, Madhan Neethiraj, Monika Kachhadiya, > Prashant Sharma, Siddhesh Phatak, and Subhrat Chaudhary. > > > Bugs: RANGER-4691 > https://issues.apache.org/jira/browse/RANGER-4691 > > > Repository: ranger > > > Description > ------- > > CUrrently only a datashare admin is able to create a DatashareInDataset > request in REQUESTED status. This should be the other way around, i.e only a > Dataset admin user should be able to create a DatashareInDataset request with > REQUESTED status. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/validation/RangerGdsValidator.java > a42a11ffb > > > Diff: https://reviews.apache.org/r/74864/diff/1/ > > > Testing > ------- > > 1. Validated that when a dataset admin is able to create a DatashareInDataset > request with REQUESTED status. > 2. Validated that when a datashare admin tries to create a DatashareInDataset > request, the api gives 400 response and a message that the user is not an > admin for the dataset. > > > Thanks, > > Anand Nadar > >
