----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74866/#review226209 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminCache.java Line 100 (original), 109 (patched) <https://reviews.apache.org/r/74866/#comment314456> Please consider having this code block (109-121) under the condition if (svcStore.serviceExists(serviceName)) { - Abhay Kulkarni On Feb. 8, 2024, 6:11 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74866/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2024, 6:11 p.m.) > > > Review request for ranger, Anand Nadar, Ankita Sinha, Asit Vadhavkar, Abhay > Kulkarni, Monika Kachhadiya, Pradeep Agrawal, Prashant Satam, Ramesh Mani, > and Siddhesh Phatak. > > > Bugs: RANGER-4695 > https://issues.apache.org/jira/browse/RANGER-4695 > > > Repository: ranger > > > Description > ------- > > RangerPolicyAdminCache maintains a cache of RangerPolicyAdmin objects, and > this cache is not being updated when the service is deleted. Hence the > response from the API might include deleted services. (Thanks @AnandNadar for > the diagnosis). > > Updated RangerPolicyAdminCache to remove entries for deleted services. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java > 8ad3e12c8 > > security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminCache.java > a64e427c5 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 00a3d9c47 > > > Diff: https://reviews.apache.org/r/74866/diff/1/ > > > Testing > ------- > > Verified that response from REST API > service/public/v2/api/zone-names/<service-name>/resource?resource:<name>=<value> > doesn't include deleted services. > > > Thanks, > > Madhan Neethiraj > >
