----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74895/#review226217 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java Lines 141 (patched) <https://reviews.apache.org/r/74895/#comment314459> Consider replacing: HashMap<String, Object> paramList = new HashMap<String, Object>(); with: Map<String, Object[]> multiValueParams; And initialize in the constructor, similar to existing member 'params'. - Madhan Neethiraj On Feb. 18, 2024, 5:01 p.m., Anand Nadar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74895/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2024, 5:01 p.m.) > > > Review request for ranger, Asit Vadhavkar, Madhan Neethiraj, Monika > Kachhadiya, Siddhesh Phatak, and Subhrat Chaudhary. > > > Bugs: RANGER-4630 > https://issues.apache.org/jira/browse/RANGER-4630 > > > Repository: ranger > > > Description > ------- > > Added multiple tagId search in /tags/tags/paginated api > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java > 4534b7848 > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > 2936c3a13 > security-admin/src/main/java/org/apache/ranger/rest/TagREST.java f05253fde > > security-admin/src/main/java/org/apache/ranger/service/RangerTagService.java > 055525f85 > > > Diff: https://reviews.apache.org/r/74895/diff/1/ > > > Testing > ------- > > Validated multiple tagId search in /tags/tags/paginated api > > > Thanks, > > Anand Nadar > >
